Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.2.0 introduced regression for empty readers #162

Closed
gabriel-vasile opened this issue Jun 30, 2021 · 0 comments
Closed

v1.2.0 introduced regression for empty readers #162

gabriel-vasile opened this issue Jun 30, 2021 · 0 comments

Comments

@gabriel-vasile
Copy link
Owner

pre v1.2.0 returned text/plain and nil error for empty inputs (same behavior as stdlib http.DetectContentType)
post v1.2.0 returns application/octet-stream and EOF error for empty inputs.

related: ipfs/kubo#8230
offending change: b1ae8bf#diff-cf06cf150d88adb18fa7da76b698e820f978ae9b6c547b3530305051e6687459L44
gabriel-vasile added a commit that referenced this issue Jul 1, 2021
@gabriel-vasile
Check for EOF in DetectReader; for #162
ff4063a 
Before v1.2.0, DetectReader returned text/plain for empty inputs.
After v1.2.0, it started returning EOF error.
This commit changes DetectReader behaviour to how it was before v1.2.0
gabriel-vasile added a commit that referenced this issue Jul 1, 2021
@gabriel-vasile
Check for EOF in DetectReader; for #162
04bcd30 
Before v1.2.0, DetectReader returned text/plain for empty inputs.
After v1.2.0, it started returning EOF error.
This commit changes DetectReader behavior to how it was before v1.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gabriel-vasile