Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for NONE in QualityGateFailMode #206

Conversation

lfojacintho
Copy link

This PR adds the support for the NONE option on the plugin property sonar.gitlab.quality_gate_fail_mode.

Using this new mode, the plugin will ignore the Quality Gate from Sonar to break the build.
This is very handy when you're using Sonarqube with Branches plugin, as the short-lived branch have only a hard-coded quality gate.

This new property allows you to customize the "Quality Gate" of your short-lived branch, by ignoring the one from Sonar and setting up your own via plugin properties sonar.gitlab.max_*_issues_gate.

This PR is related to Issue #204

@famlima
Copy link

famlima commented Mar 4, 2019

Hi,
I'd like to have this feature too.
I want to be able to pass my branche's build if sonar scan detect issues.

@lfojacintho
Copy link
Author

@famlima Cool.
We're using on our company and it helped us a lot to customize our own Quality Gate, instead of relying on Sonar limitations (hardcoded Quality Gate for short-lived branches).

We had to build and deploy the customised version, tho. It's not great, but works as a temp solution until it's merged to the main lib

@gabrie-allaigre gabrie-allaigre merged commit 448fe43 into gabrie-allaigre:master Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants