Adding on demand truncation for basic file sinks #3280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabime
reviewed
Dec 2, 2024
| @@ -26,6 +26,11 @@ SPDLOG_INLINE const filename_t &basic_file_sink<Mutex>::filename() const { | |||
| return file_helper_.filename(); | |||
| } | |||
|
|
|||
| template <typename Mutex> | |||
| SPDLOG_INLINE void basic_file_sink<Mutex>::truncate() { | |||
| file_helper_.reopen(true); | |||
There was a problem hiding this comment.
This should be locked using the mutex in the base class. See other sinks for example code.
There was a problem hiding this comment.
Gosh, sorry for that. Updated.
|
Thanks @matteodelseppia |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes log rotation can be overkill. There are use cases where it is sufficient to simply truncate without the need for managing rotated logs or archiving. To address this, I have introduced a feature that allows a basic file sink to truncate its log file on demand.