Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add explicit fmt:: and std:: to avoid ambiguous call #3259

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

LiAuTraver
Copy link
Contributor

Use three major compilers (clang++ 19, msvc 2022, g++ 14) when std::format_to and fmt::format_to are both present, the call in

       return format_to(ctx.out(), "[my_type i={}]", my.i);

would be ambiguous. The reason is unknown(even if it's in fmt::formatter or std::formatter), but it's really easy to fix this. specify std:: or fmt:: before format_to will solve the problem.

@LiAuTraver
Copy link
Contributor Author

Oops, it seems the f in fmt was eaten by commit message. never mind.😂

@gabime gabime merged commit 1245bf8 into gabime:v1.x Nov 18, 2024
16 checks passed
@gabime
Copy link
Owner

gabime commented Nov 18, 2024

Thanks @LiAuTraver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants