feat(kafka_skin.h): kafka log support #2655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add kafka log support
gabime
requested changes
Feb 28, 2023
include/spdlog/sinks/kafka_skin.h
Outdated
| protected: | ||
| void sink_it_(const details::log_msg &msg) override | ||
| { | ||
| if (producer_ != nullptr) |
There was a problem hiding this comment.
seems producer can never be null according to the ctor, so no need check if null
There was a problem hiding this comment.
Thank you for the corrections，I will fix it
gabime
requested changes
Feb 28, 2023
include/spdlog/sinks/kafka_skin.h
Outdated
|
|
||
| ~kafka_skin() | ||
| { | ||
| if (producer_ != nullptr) |
There was a problem hiding this comment.
seems producer can never be null according to the ctor, so no need check if null
There was a problem hiding this comment.
Thank you for the corrections，I will fix it
remove producer_ check
|
Thanks @vbirds |
|
@vbirds Is the word |
|
Thanks for noticing. Fixed in 2d57e3b |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add kafka log support