Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msvc_sink: support utf8 #2651

Merged
merged 2 commits into from
Feb 25, 2023
Merged

msvc_sink: support utf8 #2651

merged 2 commits into from
Feb 25, 2023

Conversation

Demonese
Copy link
Contributor

@Demonese Demonese commented Feb 23, 2023

Here's a workaround I'm using in my own project, about this issue: #2012.

This time I added an option for developers to decide whether to enable this feature.

I think this is very helpful for users who use Visual Studio but cannot modify the built-in debug output window encoding. I believe this improvement has reason to be merged.

@gabime
Copy link
Owner

gabime commented Feb 24, 2023

Thanks. I don't think new cmake variable is needed. We can use the SPDLOG_WCHAR_TO_UTF8_SUPPORT variable, like in

#ifdef SPDLOG_WCHAR_TO_UTF8_SUPPORT

@gabime
Copy link
Owner

gabime commented Feb 25, 2023

Thanks @Demonese

seker pushed a commit to seker/spdlog that referenced this pull request Mar 3, 2023
* msvc_sink: support utf8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants