Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expend support for any std::chrono::duration in spdlog::flush_every #2439

Merged
merged 1 commit into from
Jul 17, 2022
Merged

Expend support for any std::chrono::duration in spdlog::flush_every #2439

merged 1 commit into from
Jul 17, 2022

Conversation

LucasChollet
Copy link
Contributor

This allows things like:

spdlog::flush_every(std::chrono::minutes(10));
spdlog::flush_every(std::chrono::milliseconds(100));

gabime
gabime requested changes Jul 17, 2022
View reviewed changes
Copy link
Owner

@gabime gabime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looks good. Please revet the changes in the test

tests/test_async.cpp Outdated Show resolved Hide resolved
@LucasChollet
Expend support for any std::chrono::duration in spdlog::flush_every
dfe1009 
This allows things like:

spdlog::flush_every(std::chrono::minutes(10));
spdlog::flush_every(std::chrono::milliseconds(100));
@LucasChollet
Copy link
Contributor Author

LucasChollet commented Jul 17, 2022 •
edited
Loading

I removed SPDLOG_API from spdlog::flush_every declaration and replace it with inline.
It solves the CI issue.

@gabime gabime merged commit 8348406 into gabime:v1.x Jul 17, 2022
@gabime
Copy link
Owner

gabime commented Jul 17, 2022

Thanks @LucasChollet

@LucasChollet LucasChollet deleted the duration branch July 19, 2022 18:30
@gabime gabime mentioned this pull request Sep 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabime gabime gabime requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasChollet @gabime