Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage of ranges and to_hex in the same compile unit #2195

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Fix usage of ranges and to_hex in the same compile unit #2195

merged 2 commits into from
Dec 1, 2021

Commits on Dec 1, 2021

  1. Fix usage of ranges and to_hex in the same compile unit 

    When trying to use spdlog/fmt/bin_to_hex.h in the same compile unit as spdlog/fmt/bundled/ranges.h you got a compile error because there was a multiple definitions for iterable classes. This fix renames the begin() and end() getters in dump_info into getBegin()/getEnd() in order to avoid this collision.

Added an example of ranges in example.cpp to show that it actually works (an to_hex example was already there)
    @patrickroocks
    patrickroocks committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    d93cea9 View commit details
    Browse the repository at this point in the history

  2. code style fixes

    @patrickroocks
    patrickroocks committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    f304ca3 View commit details
    Browse the repository at this point in the history