Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix C++20 build resulting in deprecated implicit copy assignment operator warning #1961

Merged
merged 1 commit into from
Jun 2, 2021
Merged

Fix C++20 build resulting in deprecated implicit copy assignment operator warning #1961

merged 1 commit into from
Jun 2, 2021

Conversation

JamesJCode
Copy link

Standard has deprecated implicit copy assignment operator creation - just need to specify the default explicitly. Otherwise results in this error in Clang head:

../ExternalLibs/spdlog/include/spdlog/details/log_msg.h:17:5: error: definition of implicit copy assignment operator for 'log_msg' is deprecated because it has a user-declared copy constructor [-Werror,-Wdeprecated-copy]
    log_msg(const log_msg &other) = default;
    ^
../ExternalLibs/spdlog/include/spdlog/details/log_msg_buffer-inl.h:38:14: note: in implicit copy assignment operator for 'spdlog::details::log_msg' first required here
    log_msg::operator=(other);
             ^
1 error generated.

@gabime gabime merged commit a530b87 into gabime:v1.x Jun 2, 2021
@gabime
Copy link
Owner

gabime commented Jun 2, 2021

Thanks @JAFJ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants