Skip to content

Commit

Permalink
Better support for FMT_UNICODE in cmake
Browse files Browse the repository at this point in the history
  • Loading branch information
gabime committed Nov 1, 2024
1 parent 7a950e0 commit d373093
Showing 1 changed file with 15 additions and 2 deletions.
17 changes: 15 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,9 @@ elseif(NOT CMAKE_CXX_STANDARD)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
endif()

# under msvc make sure __cplusplus, parallel build and utf-8 enabled
# under msvc make sure __cplusplus, parallel build
if(CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
string(APPEND CMAKE_CXX_FLAGS " /Zc:__cplusplus /MP /utf-8")
string(APPEND CMAKE_CXX_FLAGS " /Zc:__cplusplus /MP")
endif()

set(CMAKE_CXX_EXTENSIONS OFF)
Expand Down Expand Up @@ -283,7 +283,20 @@ if(SPDLOG_NO_EXCEPTIONS)
target_compile_options(spdlog PRIVATE /EHs-c-)
endif()
endif()

# ---------------------------------------------------------------------------------------
# {fmt} lib requires /utf-8 flag or FMT_UNICODE=0 under MSVC
# ---------------------------------------------------------------------------------------
if(NOT SPDLOG_USE_STD_FORMAT)
if(MSVC)
if(SPDLOG_WCHAR_SUPPORT OR SPDLOG_WCHAR_CONSOLE)
target_compile_options(spdlog PUBLIC /utf-8)
else()
target_compile_definitions(spdlog PUBLIC FMT_UNICODE=0)
endif()
endif()
endif()

# Build binaries
# ---------------------------------------------------------------------------------------
if(SPDLOG_BUILD_EXAMPLE OR SPDLOG_BUILD_EXAMPLE_HO OR SPDLOG_BUILD_ALL)
Expand Down

0 comments on commit d373093

Please sign in to comment.