Skip to content

Commit

Permalink
Update CMakeLists.txt comment
Browse files Browse the repository at this point in the history
  • Loading branch information
gabime authored Nov 22, 2024
1 parent 94526fa commit 35b0417
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -274,9 +274,9 @@ if(MSVC)
target_compile_options(spdlog PRIVATE "/Zc:__cplusplus")
target_compile_options(spdlog_header_only INTERFACE "/Zc:__cplusplus")
if(SPDLOG_MSVC_UTF8)
# fmt requires the /utf-8 flag with huilding with msvc.
# fmt requires the /utf-8 flag when building with msvc.
# see https://github.com/fmtlib/fmt/pull/4159 on why the additional
# "$<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>" are needed
# "$<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>" checks are needed
target_compile_options(spdlog PUBLIC $<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>:/utf-8>)
target_compile_options(spdlog_header_only INTERFACE $<$<AND:$<COMPILE_LANGUAGE:CXX>,$<CXX_COMPILER_ID:MSVC>>:/utf-8>)
endif()
Expand Down

0 comments on commit 35b0417

Please sign in to comment.