perf: Clear data from memory when an action is removed

gabe565 · May 9, 2024 · d9a9454 · d9a9454
1 parent a90ccdd
commit d9a9454
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/com.gabe565.nightscout.sdPlugin/js/Nightscout.js b/src/com.gabe565.nightscout.sdPlugin/js/Nightscout.js
@@ -75,4 +75,9 @@ class Nightscout {
     clearTimeout(this.tickTimeout);
     this.tickTimeout = null;
   }
+
+  delete() {
+    this.stopTick();
+    delete nightscoutMap[this.context];
+  }
 }
diff --git a/src/com.gabe565.nightscout.sdPlugin/js/app.js b/src/com.gabe565.nightscout.sdPlugin/js/app.js
@@ -10,6 +10,13 @@ nightscoutAction.onDidReceiveSettings((data) =>
 
 nightscoutAction.onKeyDown((data) => new Nightscout(data).beginTick());
 
-nightscoutAction.onWillDisappear((data) => new Nightscout(data).stopTick());
+nightscoutAction.onWillDisappear((data) => {
+  const ns = new Nightscout(data);
+  if (Object.keys(data.payload.settings).length === 0) {
+    ns.delete();
+  } else {
+    ns.stopTick();
+  }
+});
 
 nightscoutAction.onWillAppear((data) => new Nightscout(data).beginTick());