Removed protobuf-to-swagger conversion artifacts #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* removed any `title: OPTIONAL` annotations that did not make sense * added `required: []` for required parameters * Added schema version, updating minor version since prefix may be a API breaking change Signed-off-by: Angel Pizarro <delagoya@gmail.com>
|
@delagoya Shall I point this PR to |
|
Yep |
adamstruck
reviewed
Mar 7, 2019
Removed `creation_time` from the required list for `tesTask` as it's marked as `readOnly` as per @adamstruck's [comment](#114 (review)).
|
@delagoya @adamstruck Are you happy to merge? |
adamstruck
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title: OPTIONALannotations that did not make senserequired: []for required parametersSigned-off-by: Angel Pizarro delagoya@gmail.com