Release notes edits. Follow-on to PR #449. #511
Conversation
|
+1 |
|
I made some partial improvements to the changelog along @jeromekelleher's suggestions. A bit more to follow. |
macieksmuga
force-pushed
the
0.6-release-notes-2
branch
from
fda17aa
to
cbbf8e5
Compare
|
I didn't realise this was a work in progress --- retracting earlier +1. |
|
|
||
| There is no longer one unitary namespace. Objects now reside in | ||
| "`org.ga4gh.models`", methods in "`org.ga4gh.methods`". | ||
|
|
||
| Updated the version number to `0.6.0-SNAPSHOT`. | ||
| Updated the version number to `0.6.a`. |
There was a problem hiding this comment.
What is the version number? I would vote for following PEP 440 and using either '0.6a1' or '0.6.0a1', depending on how many digits of precision we want.
There was a problem hiding this comment.
although we don't plan to provide bug fixes, lets go with '0.6.0a1'
anyway, just for consistency with the future
Jerome Kelleher notifications@github.com writes:
In doc/release-notes.md:
There is no longer one unitary namespace. Objects now reside in
"org.ga4gh.models", methods in "org.ga4gh.methods".-Updated the version number to
0.6.0-SNAPSHOT.
+Updated the version number to0.6.a.What is the version number? I would vote for following PEP 440 and using either
'0.6a1' or '0.6.0a1', depending on how many digits of precision we want.—
Reply to this email directly or view it on GitHub.*
|
This is great, thanks @macieksmuga! Reinstating earlier +1, modulo the comment about the version number. |
|
+1 |
| ### Changed | ||
|
|
||
| Moved `GAException` to `methods.avdl`. | ||
| * New record type `ExternalIdentifier` introduced (not currently used - reserved for sequence annotations?) |
There was a problem hiding this comment.
I would drop the editorial comment from the release notes, i.e. remove " - reserved for sequence annotations?" and resolve that separately.
There was a problem hiding this comment.
good catch @calbach, thanks!
|
+1 |
macieksmuga
force-pushed
the
0.6-release-notes-2
branch
from
050d338
to
dcbd66c
Compare
|
+1 |
3 similar comments
|
+1 |
|
+1 |
|
+1 |
|
Looks like we have lots of +1s here, so we're good to merge. @macieksmuga, can you squash the commits please? |
Release notes split into client-developer and internal changes info, per @jeromekelleher's suggestion. Follow-on to PR ga4gh#449. Resolves ga4gh#434.
macieksmuga
force-pushed
the
0.6-release-notes-2
branch
from
dcbd66c
to
6c60c95
Compare
Release notes edits. Follow-on to PR #449.
Removed
Experiment,DatasetandFragmentas requested in discussion of PR #449. I believe there are already some notes on the changed wire protocol semantics (dataSets -> dataSet in request objects, for example), I'll take a look to see what else needs to be added to that list.