Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable python 3.13 wheels #237

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Enable python 3.13 wheels #237

merged 6 commits into from
Feb 25, 2025

Conversation

gipert
Copy link
Member

@gipert gipert commented Feb 23, 2025

No description provided.

Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.30%. Comparing base (cd5d5a3) to head (5e13e60).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   74.68%   74.30%   -0.38%     
==========================================
  Files         157      157              
  Lines       22907    22907              
==========================================
- Hits        17107    17022      -85     
- Misses       5800     5885      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert
Copy link
Member Author

gipert commented Feb 24, 2025

Need to update the manylinux we are currently using to build wheels, see failure: https://github.com/g4edge/pyg4ometry/actions/runs/13486705796

I have to do it manually because of #209

@stewartboogert
Copy link
Member

@gipert I tend to build and push the docker images from GitHub Actions. Mainly because they are completely free. I do 20-30 images for our Geant4 project. Shall I set up the actions on our docker repo?

@gipert
Copy link
Member Author

gipert commented Feb 24, 2025

I guess we could do that. We would need to set it up in https://github.com/g4edge/dockerfiles and also here, and move the pyg4ometry image source from https://github.com/g4edge/dockerfiles to here...

@stewartboogert
Copy link
Member

I guess we could do that. We would need to set it up in https://github.com/g4edge/dockerfiles and also here, and move the pyg4ometry image source from https://github.com/g4edge/dockerfiles to here...

Surely we just set up the action on the 4edge/dockerfiles and push the images to dockerhub. Then everything else should work as normal. So basically on release of the g4edge/dockerfiles repo, update the images and push, a bit like this

https://github.com/bdsim-collaboration/docker/blob/main/.github/workflows/docker-build.yml

@stewartboogert
Copy link
Member

The builds are failing on usd-core, I will make this an optional dep until it is available for python 3.13

@gipert
Copy link
Member Author

gipert commented Feb 24, 2025

Surely we just set up the action on the 4edge/dockerfiles and push the images to dockerhub. Then everything else should work as normal. So basically on release of the g4edge/dockerfiles repo, update the images and push, a bit like this

but then we would need to manually trigger a build of the pyg4ometry image, every time we release a new pyg4ometry version. right?

@stewartboogert
Copy link
Member

stewartboogert commented Feb 24, 2025

Ok. You are right, my solution works for the manylinux docker image needed for building a deployment version, but not the pyg4ometry docker images.

Having said this could just move the building of the complete pyg4ometry images over to the main repo

@gipert
Copy link
Member Author

gipert commented Feb 25, 2025

I re-triggered the wheel builds here: https://github.com/g4edge/pyg4ometry/actions/runs/13524656884

@ManuelHu
Copy link
Contributor

macOS and windows 3.13 wheels are not built yet (they have to be enbabled in distribute.yml)

@gipert
Copy link
Member Author

gipert commented Feb 25, 2025

Thanks Manuel, retriggered here: https://github.com/g4edge/pyg4ometry/actions/runs/13525507416

@gipert gipert marked this pull request as ready for review February 25, 2025 18:07
@gipert
Copy link
Member Author

gipert commented Feb 25, 2025

seems like it worked 🎉 thanks everyone. I'll merge and release a new version.

@gipert gipert merged commit 0103ff9 into main Feb 25, 2025
38 checks passed
@gipert gipert deleted the gipert-patch-1 branch February 25, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants