Skip to content

Commit

Permalink
Workflow: Python - Speed up & Drop setup.py
Browse files Browse the repository at this point in the history
`python3 setup.py develop` -> `pip3 install -e .`
`python3 setup.py build_ext` -> `make`/`make build-inplace`/`make all`

...Plus: deprecated - https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html#summary
  • Loading branch information
g0tmi1k committed Feb 18, 2025
1 parent 6e23774 commit cbaffc7
Showing 1 changed file with 23 additions and 21 deletions.
44 changes: 23 additions & 21 deletions .github/workflows/python-package.yml
Original file line number Diff line number Diff line change
Expand Up @@ -114,30 +114,31 @@ jobs:
sudo apt-get satisfy --yes --no-install-recommends \
${EXTRA_DEB}
- name: Install dependencies (rust)
run: |
set -x
git clone https://github.com/jelmer/ognibuild.git /tmp/ognibuild/
pushd /tmp/ognibuild/
cargo build --verbose
# Isn't technically needed to build/compile - Disabling, to speed up CI
#- name: Install dependencies (rust)

Check warning on line 118 in .github/workflows/python-package.yml

View workflow job for this annotation

GitHub Actions / Checks

118:8 [comments] missing starting space in comment
# run: |
# set -x
# git clone https://github.com/jelmer/ognibuild.git /tmp/ognibuild/
# pushd /tmp/ognibuild/
# cargo build --verbose --release #-p dep-server
# ls -l /tmp/ognibuild/target/release/

- name: PIP install & setup
- name: PIP install
run: |
set -x
pip3 install --break-system-packages --upgrade --editable \
.
python3 setup.py develop
python3 setup.py build_ext -i
- name: Make
run: |
set -x
make
- name: Make all
run: |
set -x
make all
## Disabling, to speed up CI
#- name: Make all

Check warning on line 138 in .github/workflows/python-package.yml

View workflow job for this annotation

GitHub Actions / Checks

138:8 [comments] missing starting space in comment
# run: |
# set -x
# make all

build-container:
name: Build & Test - Debian Testing
Expand Down Expand Up @@ -165,25 +166,26 @@ jobs:
apt-get satisfy --yes --no-install-recommends \
${EXTRA_DEB}
# Isn't technically needed to build/compile
- name: Install dependencies (rust)
run: |
set -x
git clone https://github.com/jelmer/ognibuild.git /build/ognibuild/
cd /build/ognibuild/
cargo build --verbose
cargo build --verbose --release #-p dep-server
ls -l /build/ognibuild/target/release/
- name: PIP install & setup
- name: PIP install
run: |
set -x
pip3 install --break-system-packages --upgrade --editable \
.
python3 setup.py develop
python3 setup.py build_ext -i
- name: Make
run: |
set -x
make
## Make all does this, and then some - Disabling, to speed up CI
#- name: Make

Check warning on line 185 in .github/workflows/python-package.yml

View workflow job for this annotation

GitHub Actions / Checks

185:8 [comments] missing starting space in comment
# run: |
# set -x
# make

- name: Make all
run: |
Expand Down

0 comments on commit cbaffc7

Please sign in to comment.