'if constexpr' warning (c++17) #887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes warning: conditional expression is constant, consider using 'if constexpr' statement instead
Enable 'if constexpr' when c++17
|
Updated enable 'if constexpr' when c++17 is enabled. |
|
Thanks for contributing! |
|
This condition enables As a result, compilation with GCC7 in C++11 mode fails. What's the reason to have this condition? It does not make sense to me. |
|
Looks like the issue was resolved in #922
…On Wed, Jul 3, 2019 at 8:00 AM Sergey Alexandrov ***@***.***> wrote:
This condition enables if constexpr for GCC7 and above, irrespective of
the C++ standard actually used:
# elif (GLM_COMPILER & GLM_COMPILER_GCC)
# define GLM_HAS_IF_CONSTEXPR GLM_COMPILER >= GLM_COMPILER_GCC7
As a result, compilation with GCC7 in C++11 mode fails. What's the reason
to have this condition? It does not make sense to me.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#887?email_source=notifications&email_token=ABZY3MRO4ZBTD63I4BQEGY3P5S5IPA5CNFSM4HCR65TKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZEXLXY#issuecomment-508130783>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABZY3MSEERGJ2PGI23GFTU3P5S5IPANCNFSM4HCR65TA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 'if constexpr' to conditional constant expressions.
Removes warning: conditional expression is constant, consider using 'if constexpr' statement instead