Use correct precision for detail::compute_inversesqrt in glm::fastInverseSqrt #640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed when profiling my code that
glm::fastLength
's usage ofglm::fastInverseSqrt
pulls in the genericdetail::compute_inversesqrt
, which just calls out tosqrtf()
. This was the case regardless of the precision of the vectors involved.This change resolves that, by ensuring for usage with type
float
that the optimizeddetail::compute_inversesqrt
specialization is used. With this change, no call is made tosqrtf()
when callingglm::fastInverseSqrt
.I also noticed that the version under
ifdef __CUDACC__
already seemed to uselowp
so this also brings the two cases closer together in terms of implementation.