-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swapped Webpack for ts compiler #64
Conversation
…dow issues since you wont have to import code that references window useWindowSize isn't imported
… sure we can test support for both nextjs and create-react-app
Note: This PR Updates the eslint rulings and tries to enforce a stricter typescript coding standard, a separate PR should be opened after to fix all the issues caught by the new linter |
This is great @Shenato, please let me know how we can support to get this merged and released |
I've been trying to make a manual beta release for testing to make sure it works before doing a full release and merging it to main, but I was just made aware that I don't actually have access to the npm package itself. So manually releasing isn't possible for me right now. I'm trying to get it sorted as we're speaking. For now if you @UTkzhang or anyone else who's interested in helping me test and verify that this branch fixes #56, #34 as well any other Nextjs compatibility tickets that I might've missed, please feel free to do so in the meantime until i fix my npm access issues. I have some suggestions on how you could do so below Suggested method of testingYou could clone this branch, build it locally and
Otherwise If you manage to find better instructions how to use those two methods OR you have a better suggestion for how to package and test this branch please do so and let me know how you managed. |
Update: I've finally managed to publish a release candidate right here on npm Please use this version, test it out and let me know if it works with nextjs, regular client-side react and see if it solves #56 and #34 |
It's working for me on Next.js, but have type errors on
and
|
Latest update, I just lost access to this repository, since this package is under Stryda's namespace, they just recently had issues at the company and had to remove outside collaborators (including my account) from the organization on Github. So I will be attempting to make a fork of this repository, npm package and github package under my own account soon. |
as I said before, I lost write access to this repository, so I've mirrored it in my own repository. The PR is continued here Shenato/react-tournament-brackets#1 |
Closing this PR, it's merged in the new repo https://github.com/Shenato/react-tournament-brackets/ and published on npm also. This repository has no maintainers with access to it anymore more details here #78 |
This should help with the Nextjs window issues since you wont have to import code that references window
useWindowSize
isn't imported