Skip to content

Commit

Permalink
[TRANSFORM] Fix virtual device annotation issue with BYOC subgraphs (a…
Browse files Browse the repository at this point in the history
…pache#13325)

* [TRANSFORM] Fix virtual device anaotation issue with BYOC subgraphs

Heterogeneous module partitioned by BYOC has functions nodes without any VirtualDevice
definition (having FullyUnconstrained device). Ignoring the device here causes
expr_virtual_devices_ being empty when PopVirtualDevice is called assuming above PushVirtualDevice
is succeeded. PushVirtualDevice and PopVirtualDevice occurs as pairs across function body,
hence it's better to insert the The Virtual Device for Uncontrained and Pop it subsequently.

* * Test case

Co-authored-by: Siva Rama Krishna Reddy B <sivb@blr-ubuntu-ripper.qualcomm.com>
  • Loading branch information
2 people authored and fzi-peccia committed Mar 27, 2023
1 parent 8427852 commit c798ed1
Show file tree
Hide file tree
Showing 2 changed files with 42 additions and 3 deletions.
3 changes: 0 additions & 3 deletions src/relay/transforms/device_aware_visitors.cc
Original file line number Diff line number Diff line change
Expand Up @@ -94,9 +94,6 @@ void LexicalOnDeviceMixin::ExitFunctionBody() {
}

void LexicalOnDeviceMixin::PushVirtualDevice(const VirtualDevice& virtual_device) {
if (virtual_device->IsFullyUnconstrained()) {
return;
}
expr_virtual_devices_.emplace_back(virtual_device);
}

Expand Down
42 changes: 42 additions & 0 deletions tests/python/contrib/test_clml/test_compiler.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements. See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership. The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License. You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied. See the License for the
# specific language governing permissions and limitations
# under the License.
"""CLML compiler tests."""

import tvm
import numpy as np
from tvm import relay
from tvm.relay import testing
from tvm.relay.op.contrib import clml
import pytest


@tvm.testing.requires_openclml
def test_device_annotation():
mod, params = relay.testing.mobilenet.get_workload(batch_size=1)
mod = clml.partition_for_clml(mod, params)
with tvm.transform.PassContext(opt_level=3):
relay.backend.te_compiler.get().clear()
lib = relay.build(
mod,
target="opencl -device=adreno",
target_host="llvm -mtriple=aarch64-linux-gnu",
params=params,
)


if __name__ == "__main__":
tvm.testing.main()

0 comments on commit c798ed1

Please sign in to comment.