This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Persian providers #500
Merged
Persian providers #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ); | ||
|
|
||
| protected static $lastNameAscii = array( | ||
| 'ahmadi', 'rezaei', 'mohammady', 'salari', 'zare', 'chamran', 'hosseini', 'hasan', 'shahriari', 'karimi', 'majidi', 'moosavi', 'soleimani', 'ebrahimi', 'abbasi', 'majedi', 'nili', 'yazdi', 'jalili', 'babaei', 'ghasemi', |
There was a problem hiding this comment.
We'll need more random data than that...
There was a problem hiding this comment.
A few dozen names at least. Look at the other providers for an example.
One question: can't translitteration from arabic work?
|
The text generating is the same as |
|
OK for the text, sorry I thought the first method contained the text. |
|
Added more Ascii first and last names will add more persian last names in a second to. |
|
Ok, I think all issues mentioned above are resolved now. |
|
Is there anything else I should do to get this merged? |
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added persian local providers, Including Person and Internet.