This repository has been archived by the owner on Dec 11, 2020. It is now read-only.
Improve unique generator performance #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. :) |
fzaninotto
added a commit
that referenced
this pull request
Jan 4, 2015
Improve unique generator performance
|
Thanks! |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Currently the unique generator keeps the already used elements as array values and performs the lookup with
in_arrayto assert that the generated value has not already been used. This operation is a O(n) operation which becomes slower in time for large datasets generation.I refactored this operation to uses array indexes instead, which will leads to hash table lookups that are O(1) operations.
I did a little benchmark generating 10k unixTimes, the generation time is decreased from 1.77 seconds to 0.37 seconds.