Merge pull request #1321 from ViGouRCanberra/feature/add-za-local-titles

Added male and female titles for the en_ZA locale
fzaninotto · Oct 16, 2017 · 1e898a8 · 1e898a8
2 parents 62ee2d8 + b764b25
commit 1e898a8
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/src/Faker/Provider/en_ZA/Person.php b/src/Faker/Provider/en_ZA/Person.php
@@ -3,7 +3,6 @@
 namespace Faker\Provider\en_ZA;
 
 use Faker\Calculator\Luhn;
-use Faker\Provider\DateTime;
 
 class Person extends \Faker\Provider\Person
 {
@@ -127,6 +126,10 @@ class Person extends \Faker\Provider\Person
         'Pule', 'Hlophe', 'Miya', 'Moagi',
     );
 
+    protected static $titleMale = array('Mr.', 'Dr.', 'Prof.', 'Rev.', 'Hon.');
+
+    protected static $titleFemale = array('Mrs.', 'Ms.', 'Miss', 'Dr.', 'Prof.', 'Rev.', 'Hon.');
+
     protected static $licenceCodes = array('A', 'A1', 'B', 'C', 'C1', 'C2', 'EB', 'EC', 'EC1', 'I', 'L', 'L1');
 
     /**

diff --git a/test/Faker/Provider/en_ZA/PersonTest.php b/test/Faker/Provider/en_ZA/PersonTest.php
@@ -51,4 +51,18 @@ public function testLicenceCode()
 
         $this->assertContains($this->faker->licenceCode, $validLicenceCodes);
     }
+
+    public function testMaleTitles()
+    {
+        $validMaleTitles = array('Mr.', 'Dr.', 'Prof.', 'Rev.', 'Hon.');
+
+        $this->assertContains(Person::titleMale(), $validMaleTitles);
+    }
+
+    public function testFemaleTitles()
+    {
+        $validateFemaleTitles = array('Mrs.', 'Ms.', 'Miss', 'Dr.', 'Prof.', 'Rev.', 'Hon.');
+
+        $this->assertContains(Person::titleFemale(), $validateFemaleTitles);
+    }
 }