Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doctab crash (3909) temporary dirty fix #4269

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Doctab crash (3909) temporary dirty fix #4269

merged 1 commit into from
Sep 29, 2023

Conversation

matwachich
Copy link
Contributor

@matwachich matwachich commented Sep 21, 2023 •
edited by andydotxyz
Loading

Description:

This is a dirty temporary fix to the impossible to reproduce crash I'm still encountering.

Fixes #3909

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

@matwachich matwachich mentioned this pull request Sep 21, 2023
Closed
2 tasks
@coveralls
Copy link

Coverage Status

coverage: 65.277% (+0.003%) from 65.274% when pulling cf1224a on matwachich:doctab-crash-temp-fix into 67e4ecb on fyne-io:develop.

@matwachich
Copy link
Contributor Author

I just want to add that this fix works like a charm.
Never encountered the crash again, and all other functionalities are fine.

andydotxyz
andydotxyz approved these changes Sep 29, 2023
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it's all that dirty - bounds checking isn't necessarily a bad thing...

@andydotxyz
Copy link
Member

Thanks so much for this, great to have another potential crash nailed.

And congratulations on your first Fyne fix :)

@andydotxyz andydotxyz merged commit 8a807f9 into fyne-io:develop Sep 29, 2023
@matwachich
Copy link
Contributor Author

This is my first ever contribution to OSS 😁
Happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matwachich @coveralls @andydotxyz