Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions to latest #41

Closed
wants to merge 6 commits into from
Closed

Update versions to latest #41

wants to merge 6 commits into from

Conversation

lorypelli
Copy link

Let me know if you want something to not be updated, but I think it's better to update everything...

@Jacalz
Copy link
Member

Jacalz commented Dec 27, 2023

Have you built the images locally and verified that they work?

@lorypelli
Copy link
Author

lorypelli commented Dec 27, 2023

Have you built the images locally and verified that they work?

I'm having troubles make go running locally, I don't know why it doesn't want to set the PATH on linux
Also having troubles running the docker image...

@lorypelli
Copy link
Author

Have you built the images locally and verified that they work?

I need to change sha256

@Jacalz
Copy link
Member

Jacalz commented Dec 27, 2023

You should not knowingly open a PR with untested changes. That's very bad practice. If something is work in progress, at least open as a draft

@lorypelli
Copy link
Author

You should not knowingly open a PR with untested changes. That's very bad practice. If something is work in progress, at least open as a draft

Now I managed to test

@lorypelli
Copy link
Author

@Jacalz building works correctly

@Bluebugs
Copy link
Contributor

I would prefer one pr for each change and with a descriptive change in each case (like 'updating fyne to v2.4.3')

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, but watch you don't remove important content.

Has this combination of versions worked well for you?

base/Dockerfile Show resolved Hide resolved
@andydotxyz
Copy link
Member

I would prefer one pr for each change and with a descriptive change in each case (like 'updating fyne to v2.4.3')

Surely that is a lot of overhead for version bumps. If you really need it a separate commit for each managed project, but not a whole PR?

@lorypelli
Copy link
Author

lorypelli commented Dec 27, 2023

Thanks for this, but watch you don't remove important content.

Has this combination of versions worked well for you?

I would like to update also zig version but I wasn't able to find sha256, so I restored it to dev, but I didn't add back the comment, I will try to find the sha but now I don't have time...

@lorypelli
Copy link
Author

lorypelli commented Dec 27, 2023

I added the comment back for now, you can merge it if you want, it builds correctly

@lorypelli
Copy link
Author

Actually, I wasn't able to run any command inside of the docker container, it wasn't giving output of them, idk why so I recommend you test this locally by yourself

@lorypelli
Copy link
Author

I was able to find it

@Bluebugs
Copy link
Contributor

Updating zig is a high risk operation. Have you tried to build a few application with this new image using fyne-cross and tested them on their target environment.

@lorypelli
Copy link
Author

Updating zig is a high risk operation. Have you tried to build a few application with this new image using fyne-cross and tested them on their target environment.

If you think it can be an issue, let me know and I will revert the change and make another pull request when I will be able to make sure everything works with it

@lorypelli
Copy link
Author

ok, for now I reverted it, let me know if you are able to do some tests with it

@Jacalz
Copy link
Member

Jacalz commented Dec 27, 2023

I would prefer one pr for each change and with a descriptive change in each case (like 'updating fyne to v2.4.3')

Surely that is a lot of overhead for version bumps. If you really need it a separate commit for each managed project, but not a whole PR?

I agree. One commit for each would be more sensible.

@andydotxyz andydotxyz requested review from Bluebugs and removed request for andydotxyz December 30, 2023 20:50
@andydotxyz
Copy link
Member

@lorypelli lorypelli requested a review from andydotxyz 3 days ago

I'm not the right person to review this - but others are around who know it well.

@Jacalz
Copy link
Member

Jacalz commented Apr 3, 2024

Sorry @lorypelli, I think this got superseded by #43. Apologies.

@Jacalz Jacalz closed this Apr 3, 2024
@Jacalz
Copy link
Member

Jacalz commented Apr 3, 2024

I closed this now but you are more than welcome to open a new PR for that workflow misspelling. I don't think there is any need to update fixuid because the latest release of fyne-cross doesn't use it as far as I know.

@lorypelli lorypelli deleted the patch-1 branch April 4, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants