fix: interceptor fixes to make new call if access_token is not present and not throw access_token errors to sentry #3263
Conversation
…t and not throw access_token errors to sentry
Aniruddha-Shriwant
requested review from
Chethan-Fyle and
arjunaj5
as code owners
|
Caution Review failedThe pull request is closed. WalkthroughThe changes in this pull request focus on enhancing the error handling logic within the Changes
Suggested labels
Suggested reviewers
Warning Rate limit exceeded@Aniruddha-Shriwant has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 15 minutes and 50 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
| @@ -14,7 +14,7 @@ import { BehaviorSubject, of, throwError } from 'rxjs'; | |||
| import { extendedDeviceInfoMockData, extendedDeviceInfoMockDataWoApp } from '../mock-data/extended-device-info.data'; | |||
| import { HttpErrorResponse, HttpHeaders, HttpRequest } from '@angular/common/http'; | |||
|
|
|||
| describe('HttpConfigInterceptor', () => { | |||
| fdescribe('HttpConfigInterceptor', () => { | |||
There was a problem hiding this comment.
Is fdescribe() intentional?
There was a problem hiding this comment.
hey yes, I was about to fix this 🤣
Your speed ⚡
There was a problem hiding this comment.
this is fixed
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Outside diff range comments (1)
src/app/core/interceptors/httpInterceptor.ts (1)
Line range hint
70-171: Listen up! Here's some architectural wisdom, thalaiva style!While silently handling token errors is good for user experience, we need a strategy to monitor these silent failures. Consider:
- Adding a dedicated error tracking service for authentication failures
- Implementing retry mechanisms with backoff for transient failures
- Adding metrics to track the frequency of token refreshes and failures
This way, we maintain the style of silent handling while keeping an eye on system health!
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (2)
src/app/core/interceptors/httpInterceptor.spec.ts(1 hunks)src/app/core/interceptors/httpInterceptor.ts(4 hunks)
🔇 Additional comments (3)
src/app/core/interceptors/httpInterceptor.ts (2)
12-12: Mind it! The import changes are perfect, just like my style!
Adding EMPTY from rxjs is the right move to handle errors silently, exactly what we need for our token handling makeover.
91-91: Mind it! Let's verify our token validation logic!
The condition !accessToken || this.expiringSoon(accessToken) looks good, but we need to ensure we're handling all token scenarios correctly.
✅ Verification successful
Let me get more information about the token validation implementation to ensure we're handling all cases properly.
Let me try one more command to get the complete picture, mind it!
Mind it! The token validation logic is perfectly safe and sound!
Listen here, I've analyzed the token validation style like a true superstar, and here's what I found:
-
The
expiringSoonmethod is doing its job with style:- Checks token expiration with precision (2 minutes threshold)
- Has proper error handling that defaults to true (safer side)
- Uses JWT helper service for proper token validation
-
The token refresh mechanism is robust:
- Handles null/undefined tokens gracefully
- Prevents token refresh race conditions
- Automatically refreshes when token is expiring soon
The condition !accessToken || this.expiringSoon(accessToken) is not just good, it's PERFECT! Like how I handle my stunts - with complete safety and precision!
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for all token validation patterns in the codebase
echo "Checking token validation patterns..."
rg "getAccessToken|expiringSoon|refreshAccessToken" --type ts
# Look for potential token checks we might have missed
echo "Checking for other token-related patterns..."
ast-grep --pattern 'if ($_ !== null && $_ !== undefined)' --lang ts
Length of output: 9473
Script:
#!/bin/bash
# Check the implementation of expiringSoon method
echo "Checking expiringSoon implementation..."
rg "expiringSoon.*{" -A 10 --type ts
# Check token service implementation
echo "Checking TokenService implementation..."
rg "class TokenService" -A 30 --type ts
# Look for JWT token decoding patterns
echo "Checking JWT token handling..."
rg "decodeToken|parseToken|jwtHelper" --type ts
Length of output: 6468
Script:
#!/bin/bash
# Let's check the expiringSoon method with a better pattern
echo "Checking expiringSoon implementation..."
rg "expiringSoon.*\(" -B 1 -A 8 --type ts
# Check for token expiry related code
echo "Checking token expiry handling..."
rg "getExpirationDate|expiryDate|tokenExpiry" -A 3 --type ts
Length of output: 17808
src/app/core/interceptors/httpInterceptor.spec.ts (1)
Line range hint 171-177: Mind it! The error handling looks solid, macha! 🕶️
The test case now properly verifies that when access token refresh fails, the system performs a clean logout by checking:
- userEventService.logout is called
- secureStorageService.clearAll is called
- storageService.clearAll is called
This aligns perfectly with our mission to handle access token errors gracefully. Like I always say in my movies: "When system fails, clean up with style!"
| @@ -168,7 +168,7 @@ export class HttpConfigInterceptor implements HttpInterceptor { | |||
| this.secureStorageService.clearAll(); | |||
| this.storageService.clearAll(); | |||
| globalCacheBusterNotifier.next(); | |||
| return throwError(error); | |||
| return EMPTY; | |||
There was a problem hiding this comment.
🛠️ Refactor suggestion
Kabali style suggestion: Add telemetry before going silent!
While returning EMPTY for 401s is stylish, we should track these occurrences for monitoring purposes.
Here's how to do it with panache:
+ // Track authentication failures for monitoring
+ const errorContext = {
+ status: error.status,
+ blocked: error.headers.get('X-Mobile-App-Blocked'),
+ url: request.url
+ };
+ console.warn('Authentication failed - handling silently', errorContext);
return EMPTY;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| return EMPTY; | |
| // Track authentication failures for monitoring | |
| const errorContext = { | |
| status: error.status, | |
| blocked: error.headers.get('X-Mobile-App-Blocked'), | |
| url: request.url | |
| }; | |
| console.warn('Authentication failed - handling silently', errorContext); | |
| return EMPTY; |
There was a problem hiding this comment.
nopes, access_token 401 is not something we should track
There was a problem hiding this comment.
@Aniruddha-Shriwant, got it, boss! We'll skip tracking access_token 401 errors. Moving ahead!
✏️ Learnings added
Learnt from: Aniruddha-Shriwant
PR: fylein/fyle-mobile-app#3263
File: src/app/core/interceptors/httpInterceptor.ts:171-171
Timestamp: 2024-11-18T04:24:04.253Z
Learning: In the `HttpConfigInterceptor` class in `src/app/core/interceptors/httpInterceptor.ts`, do not track access_token 401 errors.
Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.
| catchError(() => { | ||
| this.userEventService.logout(); | ||
| this.secureStorageService.clearAll(); | ||
| this.storageService.clearAll(); | ||
| globalCacheBusterNotifier.next(); | ||
| return throwError(error); | ||
| return EMPTY; | ||
| }), |
There was a problem hiding this comment.
🧹 Nitpick (assertive)
Listen up! Let's add some style to our error handling, machan!
The silent error handling with EMPTY is cool, but we might miss important token refresh failures. Let's add some logging before we go silent.
Here's how to do it with style:
catchError(() => {
+ console.warn('Token refresh failed - cleaning up and logging out silently');
this.userEventService.logout();
this.secureStorageService.clearAll();
this.storageService.clearAll();
globalCacheBusterNotifier.next();
return EMPTY;
}),📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| catchError(() => { | |
| this.userEventService.logout(); | |
| this.secureStorageService.clearAll(); | |
| this.storageService.clearAll(); | |
| globalCacheBusterNotifier.next(); | |
| return throwError(error); | |
| return EMPTY; | |
| }), | |
| catchError(() => { | |
| console.warn('Token refresh failed - cleaning up and logging out silently'); | |
| this.userEventService.logout(); | |
| this.secureStorageService.clearAll(); | |
| this.storageService.clearAll(); | |
| globalCacheBusterNotifier.next(); | |
| return EMPTY; | |
| }), |
There was a problem hiding this comment.
not needed
There was a problem hiding this comment.
@Aniruddha-Shriwant, no worries, boss! We'll leave it as it is.
|
Clickup
https://app.clickup.com/t/86cwqkdza
Code Coverage
Please add code coverage here
UI Preview
Please add screenshots for UI changes
Summary by CodeRabbit
New Features
Bug Fixes
Tests