Freeze absolute paths for reduce allocations on file operations #125
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the
File
methods cast the paths it receives withFilePathValue / rb_get_path
which ultimately delegate torb_new_str_frozen
(aliased asrb_str_new4
).rb_new_str_frozen
could be experessed asstr.frozen? ? str : str.dup
.So by freezing the paths passed to the various
File.
methods, wesave at least one useless allocation each time, unless the string encoding
is incompatible with the file system.