Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow call expressions in assignment #156

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

brandonspark
Copy link
Contributor

Currently, we cannot parse programs which have things like:

Foo(context).elem = var1

which assigns var1 to the property elem of the object returned by Foo(context). You can see in the Kotlin playground that such code parses, and is attempted to evaluate:
https://pl.kotl.in/E1IajnqkH

This PR just moves call_expression so it may appear in an assignment LHS.

@brandonspark
Copy link
Contributor Author

@fwcd

@github-actions github-actions bot added the grammar Related to the grammar label Oct 17, 2024
@brandonspark
Copy link
Contributor Author

@fwcd do you think youll have any time to look at this soon? it's moderately blocking some parsing problems for us. thank you!

@fwcd fwcd merged commit e30769c into fwcd:main Dec 18, 2024
1 check passed
@fwcd
Copy link
Owner

fwcd commented Dec 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grammar Related to the grammar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants