Disable support for Kotlin scripts by default and add corresponding configuration options #536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fwcd
added
the
gradle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #511
This adds two new options,
kotlin.scripts.enabledandkotlin.scripts.buildScriptsEnabled, which control whether.ktsand.gradle.ktsscripts are handled by the language server, respectively. Due to the flakiness of the current implementation, both options are currently defaulted tofalse, i.e. scripts are no longer handled by the language server, unless manually enabled.If we manage to implement support for Kotlin scripts in a stable and performant way, we may revisit this, but until then users will have a better experience not having their language server crash because some Gradle DSL JAR was in the wrong place or having their build scripts flooded with invalid errors, because the class path was missing some Kotlin DSL script classes.