Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add none pr check #114

Merged
merged 2 commits into from
Jan 13, 2022
Merged

feat: add none pr check #114

merged 2 commits into from
Jan 13, 2022

Conversation

janos-kasa
Copy link
Contributor

This PR allows adding a none option to PR checks enabling the usage of this package to disallow merging if a label is set on a PR.

Please let me know if you need any changes from me!

@codecov
Copy link

codecov bot commented Jan 13, 2022

Codecov Report

Merging #114 (e7fabec) into main (3386cbc) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #114   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          238       241    +3     
  Branches        77        79    +2     
=========================================
+ Hits           238       241    +3     
Impacted Files Coverage Δ
src/config.ts 100.00% <ø> (ø)
src/checks.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3386cbc...e7fabec. Read the comment docs.

@github-actions github-actions bot added the feat label Jan 13, 2022
Copy link
Owner

@fuxingloh fuxingloh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, I added 1 more test and generated the dist

@fuxingloh fuxingloh merged commit b1d1a32 into fuxingloh:main Jan 13, 2022
@janos-kasa
Copy link
Contributor Author

Thanks @fuxingloh!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants