TRN-400 Emit event when listing is closed from accepted offer #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonTulp
reviewed
Sep 23, 2024
|
Btw updating benchmarks for every PR isn't required, only if you add extra storage writes or reads for an extrinsic, otherwise the changes in benchmarks would be negligible |
JCSanPedro
force-pushed
the
TRN-400-accept-offer-listing-event
branch
from
7831fcb
to
e34744d
Compare
Ah I run the benchmark as I thought emitting an extra event would contribute to the weight. |
zees-dev
approved these changes
Sep 30, 2024
surangap
approved these changes
Oct 4, 2024
Nick95550
pushed a commit
that referenced
this pull request
Oct 9, 2024
* emit FixedPriceSaleClose event if token is listed and offer is accepted * add OfferAccept variant for FixedPriceClosureReason
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the
accept_offerimpl in the marketplace pallet so that it emits aFixedPriceSaleCloseevent in the case an offer is accepted, whilst a listing for that token already exists.This allows front-end experiences to track this particular event when it occurs.