TRN-530 check token owner on simple offer #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick95550
force-pushed
the
TRN-530-prevent-offers-on-burnt-tokens
branch
from
b0e6b29
to
e216b63
Compare
Nick95550
changed the title
JasonTulp
reviewed
Sep 9, 2024
Nick95550
force-pushed
the
TRN-530-prevent-offers-on-burnt-tokens
branch
from
25e8019
to
edae085
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address an issue with the simple offer extrinsic in the marketplace pallet. The issue is that the extrinsic allows for simple offers to be made on tokens that have been burnt.
To fix this an additional check has been added to the pallet that checks the owner of the token of interest before processing. Returning an error NoTokenOwner in the failure case where the owner is None.
Related issue
PR checklist