-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substrate Upgrade to V30 #627
Conversation
cff387c
to
dd5d4b5
Compare
sp-transaction-storage-proof = { git = "https://github.com/futureversecom/substrate", branch = "polkadot-v0.9.27" } | ||
frame-system = { git = "https://github.com/futureversecom/substrate", branch = "polkadot-v0.9.27" } | ||
pallet-transaction-payment = { git = "https://github.com/futureversecom/substrate" , branch = "polkadot-v0.9.27" } | ||
sc-cli = { git = "https://github.com/paritytech/substrate", features = ["wasmtime"] , branch = "polkadot-v0.9.30" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why switch from the fork?
fp-consensus = { default-features = false, git = "https://github.com/futureversecom/frontier", branch = "polkadot-v0.9.27-TRN" } | ||
fp-rpc = { default-features = false, git = "https://github.com/futureversecom/frontier", branch = "polkadot-v0.9.27-TRN" } | ||
fp-storage = { default-features = false, git = "https://github.com/futureversecom/frontier", branch = "polkadot-v0.9.27-TRN" } | ||
fc-consensus = { default-features = false, git = "https://github.com/futureversecom/frontier", branch = "polkadot-v0.9.30-TRN" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noted that the Frontier fork also isn't pointing at the Futureverse Substrate fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we have custom changes only on the frontier side?
noticed the change from futureversecom/substrate
to paritytech/substrate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's mostly inconsequential changes, but I think we need to keep the fork. It's likely we'll use that in the very near future, and using the upstream repo will just cause headaches if we have to switch back
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on the understanding we can go to v40 right after this on the fork
59320ae
to
a5e1907
Compare
@justinfrevert i'm adding |
a5e1907
to
5cff571
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra gas RCA
frontier implements original_storage
with this PR -> polkadot-evm/frontier#871
and it creates a different gas cost for opcode sstore
. our current version returns gas_sload
and new version returns gas_sstore_reset
. The diffrence between these two which is 2900 -100 = 2800 exactly matches with the increased amount for TestCall
.
the new version seems the right way to go according to the spec docs -> https://ethereum.github.io/execution-specs/autoapi/ethereum/homestead/vm/instructions/storage/index.html#sstore and makes more sense in general.
We should proceed with the increased gas figures.
excellent finding @surangap, question, in |
This is used gas figures for TestCall between v30 and current |
closing this PR. active PR -> #660 |
TODO