Use try from over truncate from

futureversecom · Apr 5, 2024 · cd9ed41 · cd9ed41
1 parent 140a047
commit cd9ed41
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/evm-precompiles/marketplace/src/lib.rs b/evm-precompiles/marketplace/src/lib.rs
@@ -448,7 +448,8 @@ where
 			.collect::<Result<Vec<(SerialNumber, Balance)>, PrecompileFailure>>()?;
 
 		let serial_numbers: BoundedVec<(SerialNumber, Balance), Runtime::MaxTokensPerListing> =
-			BoundedVec::truncate_from(serials_unbounded);
+			BoundedVec::try_from(serials_unbounded)
+				.or_else(|_| Err(revert("Marketplace: Too many serial numbers")))?;
 		let tokens = ListingTokens::Sft(SftListing { collection_id, serial_numbers });
 		let buyer: H160 = buyer.into();
 		let buyer: Option<Runtime::AccountId> =
@@ -763,7 +764,8 @@ where
 			.collect::<Result<Vec<(SerialNumber, Balance)>, PrecompileFailure>>()?;
 
 		let serial_numbers: BoundedVec<(SerialNumber, Balance), Runtime::MaxTokensPerListing> =
-			BoundedVec::truncate_from(serials_unbounded);
+			BoundedVec::try_from(serials_unbounded)
+				.or_else(|_| Err(revert("Marketplace: Too many serial numbers")))?;
 		let tokens = ListingTokens::Sft(SftListing { collection_id, serial_numbers });
 
 		handle.record_cost(RuntimeHelper::<Runtime>::db_read_gas_cost())?;