Fix warnings.

pallet/doughnut/src/lib.rs

@@ -458,10 +458,10 @@ pub mod pallet {
 			);
 
 			// permission domain - topping validations
-			let Some(topping_payload) = doughnut_v1.get_topping(TRN_PERMISSION_DOMAIN) else {
+			let Some(mut topping_payload) = doughnut_v1.get_topping(TRN_PERMISSION_DOMAIN) else {
 				return Err(Error::<T>::TRNDomainNotfound)?
 			};
-			let topping = Topping::decode(&mut topping_payload.clone())
+			let topping = Topping::decode(&mut topping_payload)
 				.map_err(|_| Error::<T>::ToppingDecodeFailed)?;
 
 			// check topping permissions

pallet/ethy/src/ethereum_http_cli.rs

@@ -18,7 +18,7 @@ use sp_std::prelude::*;
 
 #[cfg(not(feature = "std"))]
 use sp_std::alloc::string::ToString;
-#[cfg(std)]
+#[cfg(feature = "std")]
 use std::string::ToString;
 
 use seed_pallet_common::log;

pallet/futurepass/Cargo.toml

@@ -12,7 +12,7 @@ targets = ["x86_64-unknown-linux-gnu"]
 
 [dependencies]
 hex = { workspace = true }
-hex-literal = { workspace = true, optional = true }
+hex-literal = { workspace = true }
 codec = { workspace = true }
 log = { workspace = true }
 scale-info = { workspace = true }
@@ -66,4 +66,4 @@ std = [
 	"precompile-utils/std",
 ]
 try-runtime = ["frame-support/try-runtime"]
-runtime-benchmarks = ["frame-benchmarking", "hex-literal", "seed-runtime/runtime-benchmarks"]
+runtime-benchmarks = ["frame-benchmarking", "seed-runtime/runtime-benchmarks"]

pallet/nft/src/lib.rs

@@ -59,7 +59,6 @@ mod impls;
 pub mod traits;
 mod types;
 
-pub use impls::*;
 pub use pallet::*;
 pub use types::*;
 

pallet/sft/src/lib.rs

@@ -40,7 +40,6 @@ mod weights;
 
 pub use weights::WeightInfo;
 
-pub use impls::*;
 pub use pallet::*;
 pub use types::*;
 

pallet/token-approvals/src/tests.rs

@@ -22,6 +22,7 @@ pub fn create_account(seed: u64) -> AccountId {
 	AccountId::from(H160::from_low_u64_be(seed))
 }
 
+#[allow(dead_code)]
 pub struct TestData {
 	pub coll_owner: AccountId,
 	pub coll_id: CollectionUuid,

pallet/tx-fee-pot/src/lib.rs

@@ -125,7 +125,7 @@ impl<T: Config> OnUnbalanced<FeeNegativeImbalanceOf<T>> for Pallet<T> {
 		// this amount was burnt from caller when tx fees were paid (incl. tip), move the funds into
 		// the pot
 		let note_amount = amount.peek();
-		T::FeeCurrency::deposit_creating(&Self::account_id(), note_amount);
+		let _ = T::FeeCurrency::deposit_creating(&Self::account_id(), note_amount);
 
 		Self::accrue_era_tx_fees(note_amount);
 	}
@@ -160,7 +160,7 @@ impl<T: Config> OnUnbalanced<StakeNegativeImbalanceOf<T>> for Pallet<T> {
 		let note_amount = amount.peek();
 
 		// mint `note_amount` (offsets `amount` imbalance)
-		T::StakeCurrency::deposit_creating(&Self::account_id(), note_amount);
+		let _ = T::StakeCurrency::deposit_creating(&Self::account_id(), note_amount);
 	}
 }
 

pallet/xrpl/src/types.rs

@@ -240,7 +240,7 @@ impl TryFrom<&[u8]> for XRPLTransaction {
 	type Error = &'static str;
 
 	fn try_from(value: &[u8]) -> Result<Self, Self::Error> {
-		let deserializer = &mut Deserializer::new(value.clone().to_vec(), field_info_lookup());
+		let deserializer = &mut Deserializer::new(value.to_vec(), field_info_lookup());
 		let tx_json = deserializer
 			.to_json(&TypeCode::Object, &value)
 			.map_err(|_e| "failed to convert encoded_msg to json value")?;