Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#237): implement app_status_advanced endpoint #238

Merged
merged 6 commits into from
Feb 18, 2024
Merged

feat(#237): implement app_status_advanced endpoint #238

merged 6 commits into from
Feb 18, 2024

Conversation

fusion44
Copy link
Owner

Some apps might give status information that is computationally to expensive to include in the normal status endpoint which can be polled more often.

fusion44 and others added 2 commits January 14, 2024 18:48
@fusion44
feat: implement app_status_advanced endpoint
66105b9 
Some apps might give status information that is computationally to
expensive to include in the normal status endpoint which can be polled
more often.
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
7d23fe6 
for more information, see https://pre-commit.ci
@cstenglein
Copy link
Collaborator

cstenglein commented Jan 22, 2024 •
edited
Loading

Bugs:

  • Doesn't work if there is no appId specified (just loads forever).
  • Doesn't work with electrs. Request URL is /api/v1/apps/status/electrs
    Just returns this:
{
  "id": "electrs",
  "error": "appID not in list"
}

@cstenglein cstenglein mentioned this pull request Jan 22, 2024
Merged
cstenglein
cstenglein requested changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@cstenglein cstenglein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above :)

@fusion44
fix: endpoint not working; various improvements
d0573a6 
Changes:
* fix for wrong function calls
* returns `{ "initialSyncDone": false }` or `{ "initialSyncDone": false }` when called with `electrs` now
* clarified in endpoint documentation that the endpopint isn't implemented for all backends
* returns a `400 BAD REQUEST` when appID is invalid
@fusion44
Copy link
Owner Author

fusion44 commented Jan 28, 2024 •
edited
Loading

Changes:

  • fix for wrong function calls
  • returns { "initialSyncDone": 0 } or { "initialSyncDone": 1 } when called with electrs now
  • clarified in endpoint documentation that the endpoint isn't implemented for all backends
  • returns a 400 BAD REQUEST when appID is invalid

@fusion44 fusion44 requested a review from cstenglein January 28, 2024 20:17
@cstenglein
Copy link
Collaborator

cstenglein commented Jan 29, 2024 •
edited
Loading

When calling the endpoint, I get the following result:

{
  "id": "electrs",
  "error": "script result processing error: /home/admin/config.scripts/bonus.electrs.sh status"
}

@cstenglein
Copy link
Collaborator

When is this merged?

So I can merge the webui functionality as well ;)

@fusion44 fusion44 merged commit 00e56ba into dev Feb 18, 2024
1 of 2 checks passed
@fusion44 fusion44 deleted the 237-electrs-status branch February 18, 2024 11:10
fusion44 added a commit that referenced this pull request Jan 17, 2025
@fusion44
feat(#237): implement app_status_advanced endpoint (#238)
c9e8236 
Some apps might give status information that is computationally to
expensive to include in the normal status endpoint which can be polled
more often.

closes #237
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstenglein cstenglein Awaiting requested review from cstenglein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fusion44 @cstenglein