Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Update maxAttempts to int64 #78

Merged
merged 1 commit into from
May 6, 2022

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented May 6, 2022

Updates maxAttempts to be int64 instead, there is no need to use int32.

@irvinlim irvinlim added the area/api Related to public APIs, including CRD design, configuration, etc label May 6, 2022
@irvinlim irvinlim self-assigned this May 6, 2022
@irvinlim irvinlim force-pushed the irvinlim/chore/max-attempts-int64 branch from 879dc61 to f557758 Compare May 6, 2022 16:15
@codecov
Copy link

codecov bot commented May 6, 2022

Codecov Report

Merging #78 (f557758) into main (b94aa78) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   62.59%   62.59%           
=======================================
  Files         197      197           
  Lines        9872     9872           
=======================================
  Hits         6179     6179           
  Misses       3380     3380           
  Partials      313      313           
Impacted Files Coverage Δ
apis/execution/v1alpha1/job_types.go 100.00% <ø> (ø)
apis/execution/v1alpha1/zz_generated.deepcopy.go 60.48% <100.00%> (ø)
pkg/execution/mutation/mutation.go 88.08% <100.00%> (ø)
pkg/execution/util/job/task_utils.go 94.23% <100.00%> (ø)
pkg/execution/validation/validation.go 91.94% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b94aa78...f557758. Read the comment docs.

@irvinlim irvinlim merged commit 9bcbadd into main May 6, 2022
@irvinlim irvinlim deleted the irvinlim/chore/max-attempts-int64 branch May 6, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Related to public APIs, including CRD design, configuration, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant