Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rewrite configloader #32

Merged
merged 5 commits into from
Apr 7, 2022
Merged

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Apr 7, 2022

Partially addresses #28.

Rewrite the configloader package to avoid using viper.Viper, and use mergo instead. Added more tests.

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #32 (43dad2a) into main (78a56ed) will decrease coverage by 0.02%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
- Coverage   49.05%   49.03%   -0.03%     
==========================================
  Files         160      159       -1     
  Lines        7951     7940      -11     
==========================================
- Hits         3900     3893       -7     
+ Misses       3864     3862       -2     
+ Partials      187      185       -2     
Impacted Files Coverage Δ
pkg/runtime/controllercontext/context_configs.go 16.00% <ø> (ø)
pkg/runtime/configloader/manager.go 71.25% <53.84%> (ø)
pkg/runtime/configloader/configmap_loader.go 81.72% <100.00%> (ø)
pkg/runtime/configloader/defaults_loader.go 62.16% <100.00%> (ø)
pkg/runtime/configloader/secret_loader.go 69.23% <100.00%> (ø)
.../runtime/controllercontext/mock/context_configs.go 79.48% <100.00%> (+5.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78a56ed...43dad2a. Read the comment docs.

@irvinlim irvinlim merged commit 18ce023 into main Apr 7, 2022
@irvinlim irvinlim deleted the irvinlim/feat/configloader-rewrite branch April 7, 2022 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant