Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Implement logs command #126

Merged
merged 2 commits into from
Jan 30, 2023
Merged

feat(cli): Implement logs command #126

merged 2 commits into from
Jan 30, 2023

Conversation

irvinlim
Copy link
Member

Adds a new command furiko logs, which fetches and streams logs for a single task (i.e. Pod) in a Job. The Pod must be running.

furiko-logs

@irvinlim irvinlim added kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature. area/furiko-cli Related to the command-line interface (CLI) utility. labels Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 70.11% // Head: 70.36% // Increases project coverage by +0.24% 🎉

Coverage data is based on head (c11a29a) compared to base (2a4c5c0).
Patch coverage: 81.09% of modified lines in pull request are covered.

❗ Current head c11a29a differs from pull request most recent head 0e9eb65. Consider uploading reports for the commit 0e9eb65 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
+ Coverage   70.11%   70.36%   +0.24%     
==========================================
  Files         193      194       +1     
  Lines       10049    10284     +235     
==========================================
+ Hits         7046     7236     +190     
- Misses       2631     2661      +30     
- Partials      372      387      +15     
Impacted Files Coverage Δ
pkg/cli/common/common.go 54.25% <50.00%> (-0.30%) ⬇️
pkg/cli/cmd/cmd_logs.go 81.25% <81.25%> (ø)
pkg/cli/cmd/cmd.go 87.23% <100.00%> (+0.27%) ⬆️
pkg/utils/testutils/assert.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irvinlim irvinlim merged commit 17a833b into main Jan 30, 2023
@irvinlim irvinlim deleted the irvinlim/feat/cli-logs branch January 30, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/furiko-cli Related to the command-line interface (CLI) utility. kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant