Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Implement --watch flag #118

Merged
merged 2 commits into from
Jan 28, 2023
Merged

feat(cli): Implement --watch flag #118

merged 2 commits into from
Jan 28, 2023

Conversation

irvinlim
Copy link
Member

@irvinlim irvinlim commented Jan 27, 2023

  1. Implements --watch for list subcommands.
  2. Refactor flag initialization for subcommands.
  3. Re-implement TablePrinter using github.com/liggitt/tabwriter.
  4. Change YAML and JSON output for lists from metav1.List to individual documents/objects.

@irvinlim irvinlim added area/furiko-cli Related to the command-line interface (CLI) utility. kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature. labels Jan 27, 2023
@irvinlim irvinlim force-pushed the irvinlim/feat/cli-watch branch from c3742e8 to 9cc3904 Compare January 27, 2023 19:39
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 64.34% // Head: 64.47% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (ad0ef54) compared to base (1efeecb).
Patch coverage: 83.26% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   64.34%   64.47%   +0.13%     
==========================================
  Files         207      208       +1     
  Lines       11143    11244     +101     
==========================================
+ Hits         7170     7250      +80     
- Misses       3580     3603      +23     
+ Partials      393      391       -2     
Impacted Files Coverage Δ
pkg/cli/cmd/watch.go 35.48% <35.48%> (ø)
pkg/cli/cmd/cmd_list_job.go 81.06% <80.48%> (+2.35%) ⬆️
pkg/cli/cmd/cmd_list_jobconfig.go 88.80% <80.95%> (+0.79%) ⬆️
pkg/cli/cmd/common.go 51.80% <84.61%> (+6.80%) ⬆️
pkg/runtime/testing/command.go 77.16% <95.34%> (+6.19%) ⬆️
pkg/cli/cmd/cmd_get.go 88.46% <100.00%> (+4.25%) ⬆️
pkg/cli/cmd/cmd_get_job.go 76.35% <100.00%> (+1.18%) ⬆️
pkg/cli/cmd/cmd_get_jobconfig.go 75.30% <100.00%> (+2.18%) ⬆️
pkg/cli/cmd/cmd_list.go 90.00% <100.00%> (+4.28%) ⬆️
pkg/cli/printer/printer.go 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@irvinlim irvinlim force-pushed the irvinlim/feat/cli-watch branch from 9cc3904 to c23423a Compare January 28, 2023 05:10
@irvinlim irvinlim force-pushed the irvinlim/feat/cli-watch branch from 603a07e to ad0ef54 Compare January 28, 2023 06:53
@irvinlim irvinlim marked this pull request as ready for review January 28, 2023 10:15
@irvinlim irvinlim merged commit 551852d into main Jan 28, 2023
@irvinlim irvinlim deleted the irvinlim/feat/cli-watch branch January 28, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/furiko-cli Related to the command-line interface (CLI) utility. kind/feature Categorizes issue or PR as related to a new, well-defined and agreed-upon feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant