Enable "u()" shortcut also for empty tables

[ajthinking]

I was about to check out issue 50, but after testing

laravel new tinx-issue-50
composer require ajthinking/tinx
php artisan tinx
>>u()::someStatic()

I got PHP Fatal error: Call to undefined function u() in Psy Shell code on line 1

It seems the shortcut to App\User also required at least one item in the database. That makes sense for $u and $u_ but u() can be needed in other situations where table is still empty. Hence I moved it outside of the try block. What do you think?

[furey]

Hi @ajthinking,

Looking into this deeper, it appears there were various issues around tableless_models causing strange behaviour with Tinx's defined shortcuts in general.

I've just patched (hopefully) all those issues on top of your PR and merged it back into master, pushing a new v2.3.0 release.

If you have time, can you pull in v2.3.0 and confirm the tableless_models configuration option works as it always should have, namely…

• If set to false, only models with database tables return working shortcuts via names()
• If set to true, all models/classes found in model_paths configuration option paths return working shortcuts via names()

Cheers!

[ajthinking]

Ops, you're right! Thanks! Just tested 2.3.0 and it works! $u / $u_ are not defined when tableless_models=false for a non existing DB. 👍

Though a small issue with function shortcuts (?). Even though u() does not list in names() for false it is still available for execution.

I can dig into it later.
PS nice find on the Observer/Serviceprovider-bug

[furey]

Hi @ajthinking,

Nice catch dude!

I've just pushed a v2.3.1 patch release that (hopefully) fixes that function shortcut issue.

The patch undoes what your PR originally did (you moved the function shortcut definition outside of the try/catch block; I moved it back again), but I think we've ended up where the codebase should have been when we started, so all the back and forth was worth it!

Cheers!

🤓🙏🤓