Tcp timeout #46
Open
Tcp timeout #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timeouts were hardcoded to 0.1, despite having an input variable in Tasks(). This was corrected by moving specification to the run_blockwise() function call via the "tcp_timeout" kwarg. Task() no longer takes a timeout argument for inputs. convenience.run_blockwise() takes tcp_timeout, defaulting to 0.1, as previously was hardcoded.
|
Note: Current master branch also fails mypy. |
|
The ubuntu tests seem to fail after a 6hr timeout, I don't see any changes that would would result in hanging forever though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeout for tcp messaging was hardcoded to 0.1, which empirically resulted in excessive worker terminations, drastically slowing processing.
Originally a "timeout" kwarg was included for Task() definition, but this information is not currently applied in the master branch code.
I found it more appropriate and parsimonious to include a "tcp_timeout" kwarg in the convenience.run_blockwise() call that initializes scheduling of tasks.