Upgrade to Angular 10 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WuglyakBolgoink
suggested changes
Oct 3, 2020
|
@WuglyakBolgoink Fixed license file |
|
@fundsaccess can you look at this PR? |
|
Hello @Aracturat, thanks for your PR. We will review it and give you feedback. Kind regards, |
fundsaccess
approved these changes
Oct 9, 2020
There was a problem hiding this comment.
Hi @Aracturat ,
thank you so much for this PR. It's looking very good. Just a suggestion for the future, before you would contribute to this project, please create an issue and let's talk about it at first. Minor fixes or improvements that don't have with the upgrade to do should be handled in separate issues and PRs.
We are looking forward to your next contribution!
Kind regards,
fundsaccess F/E Team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade this library to support Angular 10. Please publish it after accept.