makefile updates #334
Merged
makefile updates #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpassini
approved these changes
Sep 9, 2024
| @@ -31,5 +31,5 @@ if [[ "$(${PROTOC} --version 2>/dev/null)" != "libprotoc 3.${PROTOC_VERSION}" ]] | |||
| mkdir -p .tmp/protoc | |||
| curl -L "https://github.com/google/protobuf/releases/download/v${PROTOC_VERSION}/protoc-${PROTOC_VERSION}-${PROTOC_OS}-${PROTOC_ARCH}.zip" > .tmp/protoc/protoc.zip | |||
| pushd ./.tmp/protoc && unzip protoc.zip && popd | |||
| touch -c ./.tmp/protoc/bin/protoc | |||
There was a problem hiding this comment.
I'm missing the subtlety here. This command will never fail, right? So what we want to do is really change its modification time? Why?
There was a problem hiding this comment.
Unpacking protoc gives it a very old timestamp, but we reference it as a dependency in the Makefile, so we actually want to have it use whatever time it got unpacked. Otherwise, changing protoc versions won't force a rebuild.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.