Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zk library to use our fork. #17

Merged
merged 2 commits into from
Oct 16, 2020
Merged

Conversation

claygoddard
Copy link
Contributor

Use our fork for now to fix some session lost issues.
Additionally, update import package to reference new package name.

Use our fork for now to fix some session lost issues.
Additionally, update import package to reference new package name.
@claygoddard
Copy link
Contributor Author

Need to do this first so that the packages match up when I update our internal repo.

@donjaime
Copy link
Contributor

Seems reasonable. But I will defer to Jh and Scottb.

Copy link
Member

@dragonsinth dragonsinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but why not just reference fullstorydev/zk in code instead of using a replace directive? Until we can get a patch landed go-zookeeper/zk#34 -- and there doesn't seem to be much interest in it :( -- this lib won't work with any other version of zk.

@claygoddard
Copy link
Contributor Author

LGTM, but why not just reference fullstorydev/zk in code instead of using a replace directive? Until we can get a patch landed go-zookeeper/zk#34 -- and there doesn't seem to be much interest in it :( -- this lib won't work with any other version of zk.

That's fair. Was doing it for clarity, but I'll just point directly.

@claygoddard claygoddard merged commit 5bd27d9 into master Oct 16, 2020
@claygoddard claygoddard deleted the clay/update-zk-library branch October 16, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants