Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PodSpec revisioni to avoid importing the Info.plist #115

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

JoelGerboreLaser
Copy link
Contributor

Updated the podspec: removed the import of the Info.plist to avoid build problems

@fulldecent
Copy link
Owner

Thank you for sharing. Can you please say if there is an source where you got this approach from?

Please see the note here https://github.com/fulldecent/FDTake#contributing

^ There are many projects that depend on this build instruction so if it wrong I would like to fix it upstream first.

@JoelGerboreLaser
Copy link
Contributor Author

I've made another small modification to correctly separate the code files (.swift, .h, .m) in pod spec source files and .strings in resource.

The upstream project already in the PROJECT_NAME.podspec has a more specific import in s.source_files = 'Source/.{h,m,swift}'.
AlamoFire too uses a more specific regex to import only correct code files "source_files": "Source/
.swift"

@fulldecent fulldecent merged commit 4f309f8 into fulldecent:master Feb 7, 2019
@fulldecent
Copy link
Owner

Looks great, thank you.

@JoelGerboreLaser
Copy link
Contributor Author

Thanks!
Will you release an updated podspec on Cocoapods?

@fulldecent
Copy link
Owner

I'm having some trouble building/releasing.

Just to get my bearings straight I started back upstream at fulldecent/swift6-module-template#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants