Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing rust version in CI because TOML toolchain was not being honored previously. #24

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Fixing rust version in CI because TOML toolchain was not being honored previously. #24

merged 4 commits into from
Feb 14, 2023

Conversation

NatPRoach
Copy link
Contributor

@NatPRoach NatPRoach marked this pull request as ready for review February 7, 2023 18:26
@NatPRoach NatPRoach requested a review from tfenne February 7, 2023 18:33
nh13
nh13 reviewed Feb 7, 2023
View reviewed changes
.github/workflows/build_and_test.yml Outdated
toolchain: stable
override: true
- name: Setup rust toolchain
run: rustup show
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't removing the with work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or use: https://github.com/dtolnay/rust-toolchain

@NatPRoach NatPRoach marked this pull request as draft February 7, 2023 22:55
@NatPRoach NatPRoach marked this pull request as ready for review February 7, 2023 22:58
@NatPRoach NatPRoach merged commit 73d382c into main Feb 14, 2023
@NatPRoach NatPRoach deleted the fix_rustversion_in_ci branch February 14, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfenne tfenne tfenne approved these changes

@nh13 nh13 nh13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NatPRoach @nh13 @tfenne