Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle varargs parameters in FMethod.setDeclaration #55

Merged
merged 2 commits into from
Aug 24, 2020
Merged

Properly handle varargs parameters in FMethod.setDeclaration #55

merged 2 commits into from
Aug 24, 2020

Conversation

Clashsoft
Copy link
Member

@Clashsoft Clashsoft commented Aug 24, 2020 •
edited
Loading

Bugfixes

Closes #54

@Clashsoft
fix: Properly handle varargs parameters in FMethod.setDeclaration
f9aa16a 
Previously, varargs parameters were converted to their element type,
as if the `...` was not present.
@Clashsoft
test: Add FMethodTest
5367345
@Clashsoft Clashsoft added bug Something isn't working regression Things that used to work, but are broken again labels Aug 24, 2020
@Clashsoft Clashsoft added this to the v1.2.2 milestone Aug 24, 2020
@Clashsoft Clashsoft self-assigned this Aug 24, 2020
@Clashsoft Clashsoft merged commit b0805ee into bugfix Aug 24, 2020
@Clashsoft Clashsoft deleted the fix/varargs-methods branch August 24, 2020 09:38
@Clashsoft Clashsoft linked an issue Aug 24, 2020 that may be closed by this pull request
FMethod does not support varargs in declaration #54
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Clashsoft Clashsoft

Labels
bug Something isn't working regression Things that used to work, but are broken again
Projects
None yet
Milestone
v1.2.2
Development

Successfully merging this pull request may close these issues.

FMethod does not support varargs in declaration
1 participant
@Clashsoft