This repository has been archived by the owner on Jan 26, 2025. It is now read-only.
Fix command #20
Merged
Fix command #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstallation of Fuelviews packages and running their install commands. The command copies a workflow file from a stub to the desired destination, creating any necessary directories along the way.
…lass. The reasoning behind this change is to add a new command to the package for installing a workflow.
…descriptive command name. Added new files CpanelAutoDeploy.php and CpanelAutoDeploy facade to the codebase for implementing Cpanel auto-deployment functionality.
…tive command signature, adjust the source path to be relative to the package's base directory, and add error handling for file existence and directory creation.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a critical issue in the
InstallWorkflowCommand.phpfile. The source path for the workflow template file is adjusted to be relative to the package's base directory, ensuring the correct file is accessed during the command execution.Additionally, a check has been added to verify the existence of the source file before proceeding with the file operations. If the source file does not exist, an error message is displayed, and the command execution is halted with an exit code of 1 to prevent further issues.
Furthermore, the logic for creating directories has been enhanced to handle the case where the destination directory does not exist. If the directory creation fails, an error message is logged to inform the user about the issue.
Overall, these changes improve the robustness and reliability of the
InstallWorkflowCommand, ensuring that the workflow template file is correctly accessed and copied while handling edge cases gracefully.