Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass Parameters at Jail creation time #15

Merged
merged 2 commits into from
Jul 8, 2018

Conversation

fabianfreyer
Copy link
Contributor

See #1.

Based on Work by @Joppich.

@fabianfreyer fabianfreyer added the enhancement New feature or request label Jul 7, 2018
@fabianfreyer fabianfreyer added this to the 0.0.6 milestone Jul 7, 2018
@fabianfreyer fabianfreyer requested a review from sashakm July 7, 2018 16:56
@fabianfreyer
Copy link
Contributor Author

This brings down the jail startup time by around 20%:
before:

test start_stop_ipjail          ... bench:      52,498 ns/iter (+/- 714)
test start_stop_ipv4jail        ... bench:      51,678 ns/iter (+/- 1,488)
test start_stop_ipv6jail        ... bench:      52,260 ns/iter (+/- 548)
test start_stop_jail            ... bench:      50,832 ns/iter (+/- 462)

after:

test start_stop_ipjail          ... bench:      39,718 ns/iter (+/- 10,643)
test start_stop_ipv4jail        ... bench:      39,012 ns/iter (+/- 1,429)
test start_stop_ipv6jail        ... bench:      39,336 ns/iter (+/- 1,375)
test start_stop_jail            ... bench:      38,433 ns/iter (+/- 1,524)

@fabianfreyer fabianfreyer added the performance Performance Optimizations label Jul 7, 2018
@fabianfreyer fabianfreyer mentioned this pull request Jul 8, 2018
21 tasks
@fabianfreyer fabianfreyer merged commit 0b67dc4 into fubarnetes:dev Jul 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request performance Performance Optimizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants